Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Fix bodySize in onResourceReceived end, fix #10156 #13834

Merged
1 commit merged into from
Jan 8, 2018
Merged

Fix bodySize in onResourceReceived end, fix #10156 #13834

1 commit merged into from
Jan 8, 2018

Conversation

erikdubbelboer
Copy link
Contributor

No description provided.

@erikdubbelboer erikdubbelboer mentioned this pull request Dec 27, 2015
Merged
@erikdubbelboer
Copy link
Contributor Author

If this gets merged #13195 can be closed.

@zackw
Copy link
Contributor

zackw commented Dec 27, 2015

I don't understand the core code changes well enough to review them, but, for the test case: please try to use the Python webserver for your test case, not the PJS-embedded webserver. It can be extended with .py files in the test/www directory. If you can't make it work we can discuss changing it.

(The embedded webserver has architectural problems that can cause deadlocks when used like you're doing.)

@erikdubbelboer
Copy link
Contributor Author

I updated the pull request so the test uses the python webserver.

@erikdubbelboer erikdubbelboer mentioned this pull request Feb 1, 2016
Closed
@vitallium vitallium force-pushed the master branch 2 times, most recently from 1842ba8 to 842715b Compare March 15, 2016 17:40
@tiwilliam tiwilliam mentioned this pull request Mar 24, 2016
Closed
@tiwilliam
Copy link

I can confirm that this PR fixes my issue in phantomas when trying calculate size of chunked content. Would love to see this merged.

macbre/phantomas#614

@abozhilov
Copy link

@erikdubbelboer any chances for new PR compatible with 2.1.1? #13908 breaks the current patch, as you know.

@vitallium vitallium force-pushed the master branch 2 times, most recently from e024f31 to 5d99f2a Compare May 19, 2016 20:53
@ghost
Copy link

ghost commented Dec 21, 2017 •
edited by ghost
Loading

Will take care of this in 2 days' time. Will merge this.

@ghost ghost merged commit 545b03c into ariya:master Jan 8, 2018
ghost pushed a commit that referenced this pull request Jan 8, 2018
Fix for #13834
af89fbd
ghost pushed a commit that referenced this pull request Jan 8, 2018
Fixing #13834
8d97100
@rumblefrog rumblefrog mentioned this pull request Mar 4, 2018
Closed
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikdubbelboer @zackw @tiwilliam @abozhilov