Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Added fromCache attribute to network response #12090

Merged
2 commits merged into from
Jan 8, 2018
Merged

Added fromCache attribute to network response #12090

2 commits merged into from
Jan 8, 2018

Conversation

kokoc
Copy link
Contributor

@kokoc kokoc commented Mar 26, 2014

Added additional attribute to the response. This should help to detect real world client behavior in performance testing.

@JamesMGreene
Copy link
Collaborator

I like this idea. In recent versions of the Chrome Dev Tools "Network" tab, I've noticed that, for some cached resources, they no longer return 304 status codes but rather are returning 200 status codes and the "Size/Content" column says "(from cache)":

screen shot 2014-03-26 at 10 17 39 am

@vitallium
Copy link
Collaborator

Agreed. I think we can merge this.

@vitallium vitallium force-pushed the master branch 2 times, most recently from b3cd914 to c4df640 Compare June 27, 2015 08:43
@vitallium vitallium force-pushed the master branch 2 times, most recently from 573e969 to b483dd6 Compare October 6, 2015 20:31
@vitallium vitallium force-pushed the master branch 2 times, most recently from 1842ba8 to 842715b Compare March 15, 2016 17:40
@vitallium vitallium force-pushed the master branch 2 times, most recently from e024f31 to 5d99f2a Compare May 19, 2016 20:53
@ghost ghost merged commit f1f3cd7 into ariya:master Jan 8, 2018
ghost pushed a commit that referenced this pull request Jan 8, 2018
ghost pushed a commit that referenced this pull request Jan 8, 2018
@rumblefrog rumblefrog mentioned this pull request Mar 4, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants