Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Fix typo in Contributing Guide #14550

Closed
vjwilson opened this issue Sep 21, 2016 · 1 comment
Closed

Fix typo in Contributing Guide #14550

vjwilson opened this issue Sep 21, 2016 · 1 comment

Comments

@vjwilson
Copy link
Contributor

There is a minor typo in the Contributing Guide, regarding how to name feature branches.

Under the subheading Use Feature Branch, the first instead of is confusing and should be removed.

Give it a meaningful name instead of, e.g. prevent-zero-divide instead of just fix

I read about the need for help with fixing issues, e.g., in #14541, and I want to help out. Rather than just add to the list of issues, I will submit a PR for this, as a way to "get my feet wet".

vjwilson added a commit to vjwilson/phantomjs that referenced this issue Sep 21, 2016
Removes a minor typo, regarding how to name feature branches.
Fixes ariya#14550
@ghost
Copy link

ghost commented Sep 21, 2016

On 21/09/16 19:55, Van Wilson wrote:

Rather than just add to the list of issues, I will submit a PR for
this, as a way to "get my feet wet".

Good on you Van. I started perusing the source and issues few days ago
before my weekly time budget for extra-curricula OSS ran out.
Hopefully next week with a new time quota I can "get my feet wet" too! :-)

ariya pushed a commit that referenced this issue Sep 22, 2016
Removes a minor typo, regarding how to name feature branches.
Fixes #14550
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant