Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

The Webserver module shouldn't assume that headers in Requests must be upper-case #11421

Closed
detro opened this issue Jun 20, 2013 · 3 comments · Fixed by #11422
Closed

The Webserver module shouldn't assume that headers in Requests must be upper-case #11421

detro opened this issue Jun 20, 2013 · 3 comments · Fixed by #11422

Comments

@detro
Copy link
Collaborator

detro commented Jun 20, 2013

This issue was initially raised here: https://github.com/detro/ghostdriver/issues/204.

This issue brakes webdriverjs, that correctly follows the RFC 2616.

The RFC indeed says:

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.
@detro detro mentioned this issue Jun 21, 2013
Merged
@csnover
Copy link

csnover commented Jul 15, 2014

This fix does not seem to have been ported into the 1.9 branch.

jaredp pushed a commit to jaredp/phantomjs that referenced this issue Oct 29, 2014
@detro @jaredp
WebServer Headers for Request are treated case-insensitive
3cafb82 
To achieve this, Request Headers are stored in both "original" and "lowercase".
In this way we don't mangle with the request object we have received, while
still be able to handle headers when NOT in the classic "Camel-Case" format.

Fixes ariya#11421.

Conflicts:
	test/webpage-spec.js
@csnover csnover mentioned this issue Nov 7, 2014
Closed
@arikon
Copy link

arikon commented Apr 25, 2015

@detro Please back port this fix to the 1.9.x branch

@arikon arikon mentioned this issue Apr 25, 2015
Closed
@christian-bromann christian-bromann mentioned this issue Jun 30, 2015
Closed
Lochlan added a commit to Lochlan/LochlanMcIntosh.com that referenced this issue Jul 1, 2015
@Lochlan
Upgrade WebdriverIO to 3.0, upgrade PhantomJS to 2.0 to support it
119a173 
It doesn't seem to work with Phantom 1.9.x, see ariya/phantomjs#11421

The phantomjs package.json entry is using the forked phantom2 package, at the commit right before the package's name was changed from "phantomjs" to "phantomjs2"—allowing phantomjs2 to satisfy the karma-phantomjs-launcher peer dependency requirement.  Note that this does not work in Linux.  When the official phantomjs npm package is upgraded to 2.0 it would be a good idea to switch back to it.
@ghost ghost mentioned this issue Jul 1, 2015
Merged
@ghost
Copy link

ghost commented Jul 1, 2015

👍 For back porting this fix to 1.9.x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WebServer Headers for Request are treated case-insensitive
3 participants
@arikon @detro @csnover