This repository has been archived by the owner on May 30, 2023. It is now read-only.
Feature: Expose frameName to the WebPage API #11374
Labels
Comments
kanzure
added a commit
to kanzure/phantomjs
that referenced
this issue
Jun 14, 2013
A null QWebFrame will cause frameName sent to onNavigationRequested to equal "" (an empty QString). see ariya#11374 ariya#11374
vitallium
pushed a commit
that referenced
this issue
Oct 6, 2015
An additional parameter is now passed to onNavigationRequested with the name of the frame that originated the navigation request. isMainFrame can be emulated by checking if frameName is equal to an empty string, but hasn't been removed from the function signature. Issue: #11374
vitallium
added a commit
that referenced
this issue
Oct 6, 2015
An additional parameter is now passed to onNavigationRequested with the name of the frame that originated the navigation request. isMainFrame can be emulated by checking if frameName is equal to an empty string, but hasn't been removed from the function signature. Issue: #11374
vitallium
pushed a commit
that referenced
this issue
Oct 6, 2015
An additional parameter is now passed to onNavigationRequested with the name of the frame that originated the navigation request. isMainFrame can be emulated by checking if frameName is equal to an empty string, but hasn't been removed from the function signature. Issue: #11374
|
Due to our very limited maintenance capacity, we need to prioritize our development focus on other tasks. Therefore, this issue will be automatically closed (see #15395 for more details). In the future, if we see the need to attend to this issue again, then it will be reopened. Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Many of the WebPage callbacks are difficult to use without knowing which frame caused a certain call to occur.
To that end, I have modified the API as follows:
11371 - updates
onNavigationRequestedto passframeNameas an additional last parameter. Add frameName to onNavigationRequested. #11371 does not remove theisMainFramebool fromonNavigationRequested.11373 - sets
frameNamein the hash passed toonResourceRequested,onResourceReceivedandonResourceError.Many of the other API calls would be much more useful with
frameName.@JamesMGreene has mentioned in the IRC channel that we should eventually consider implementing
QWebFrameas an object in the JavaScript API. I definitely agree, although I wasn't up for implementing that today and just did #11371 and #11373.The text was updated successfully, but these errors were encountered: