Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfp reset on optical xcvrs leave the port in low-power mode #121

Open
arista-nwolfe opened this issue Feb 25, 2025 · 1 comment
Open

sfp reset on optical xcvrs leave the port in low-power mode #121

arista-nwolfe opened this issue Feb 25, 2025 · 1 comment

Comments

@arista-nwolfe
Copy link

arista-nwolfe commented Feb 25, 2025

There is a sonic-mgmt ptest which fails due to this issue platform_tests/api/test_sfp.py::TestSfpApi::test_reset.

But it's also reproduce manually:

  1. sfputil reset <port>
  2. <port stays operationally down>
  3. sfputil lpmode off
  4. <port comes back up>

We only started to notice this recently because the test was only updated to check port status recently
sonic-net/sonic-mgmt#16375

https://github.com/aristanetworks/sonic-qual.msft/issues/156#issuecomment-2162873963
Looking at this comment in a issue discussing low-power mode it suggests XCVRD will only take the port out of low-power mode in these scenarios:

  1. Deasserting the hardware low power mode during xcvr init
  2. Asserting the hardware low power mode when a xcvr is removed/denit.

Since sfp reset won't fall under either of these scenarios it makes sense that currently xcvrd doesn't take the port out of low-power mode.

@mihirpat1
Copy link

@arista-nwolfe Can you please elaborate on which change specifically from the below PR causes the current issue?
sonic-net/sonic-mgmt#16375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants