Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(j2lint): Fix spelling delimeter -> delimiter #39

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Fix(j2lint): Fix spelling delimeter -> delimiter #39

merged 2 commits into from
Jun 13, 2022

Conversation

carlbuchmann
Copy link
Member

Fix spelling delimeter -> delimiter

@carlbuchmann carlbuchmann requested a review from gmuloc June 10, 2022 19:49
@carlbuchmann
Copy link
Member Author

carlbuchmann commented Jun 10, 2022 •
edited
Loading

PR aristanetworks/avd#1875 on ansible-avd repo needs to be merged immediately after merging this PR to avoid breaking CI.

This was referenced Jun 10, 2022
Merged
Merged
@carlbuchmann carlbuchmann self-assigned this Jun 10, 2022
@carlbuchmann carlbuchmann changed the title DOC(j2lint): Fix spelling delimeter -> delimiter Fix(j2lint): Fix spelling delimeter -> delimiter Jun 10, 2022
@gmuloc
Refactor: keep 'delimerter' support for backward compatibility
e4d4e5f 
* rename the rule file as j2lint depends on it to load the plugin
ClausHolbechArista
ClausHolbechArista approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Having the deprecated variant will allow us to fix projects leveraging j2lint without breaking CI at any time. Since j2lint is still a 0.x, we can decide to remove the deprecated support again before releasing.

@ClausHolbechArista ClausHolbechArista merged commit 8f66de1 into aristanetworks:devel Jun 13, 2022
@carlbuchmann carlbuchmann deleted the fix-delimeter-delimiter branch June 13, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@carlbuchmann carlbuchmann

Labels
EPIC - j2lint Initial release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlbuchmann @ClausHolbechArista @gmuloc