Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Refactor eos_designs structured_config code for underlay router_bgp #4953

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Refactor eos_designs structured_config code for underlay router_bgp

Component(s) name

arista.avd.eos_designs

Proposed changes

Refactoring to use schema classes for output in underlay/router_bgp.py.

How to test

Existing tests should not change.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners January 31, 2025 06:42
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4953
# Activate the virtual environment
source test-avd-pr-4953/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/underlay-output-router_bgp-classes#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/underlay-output-router_bgp-classes --force
# Optional: Install AVD examples
cd test-avd-pr-4953
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jan 31, 2025
@gmuloc gmuloc added this to the v5.2.0 milestone Jan 31, 2025
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment to track the issue

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jan 31, 2025
Copy link

@gmuloc gmuloc merged commit a0cf465 into aristanetworks:devel Jan 31, 2025
44 checks passed
joelbreton2 pushed a commit to joelbreton2/avd that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants