fix-typescript-support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 space indent is fine. And thanks for the contribution. Hopefully will be reviewed and merged today. Thanks. |
arifszn
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with false positive ts validation errors.
Also removed unnecessary React import and changed imports to named imports. The file being formatted and indented by 2 spaces was a byproduct of prettier formatting on save. Seeing there was no style guidelines to contributing, and 2 space indentations is pretty much almost universally agreed upon in react and javascript in general, I didn't think this would be too much of an issue. However, if this is a problem, I can resubmit it unformatted with 4 spaces.