Make the tests pass#2
Merged
arifibrahim4 merged 4 commits intoarifibrahim4:feature/sms-core-v2-and-test-recoder-migrationfrom Apr 25, 2022
petrsvihlik:petrsvihlik/sms-migration-v2
Merged
Make the tests pass#2arifibrahim4 merged 4 commits intoarifibrahim4:feature/sms-core-v2-and-test-recoder-migrationfrom petrsvihlik:petrsvihlik/sms-migration-v2
arifibrahim4 merged 4 commits intoarifibrahim4:feature/sms-core-v2-and-test-recoder-migrationfrom
petrsvihlik:petrsvihlik/sms-migration-v2
Conversation
arifibrahim4
merged commit 1efbe0f
into
arifibrahim4:feature/sms-core-v2-and-test-recoder-migration
arifibrahim4
added a commit
that referenced
this pull request
Apr 26, 2022
* sms core v2 migration changes * fixed build issue * unit test fixes * record test mode fix * recording updated * migrated to new test recorder version * Make the tests pass (#2) format and test fixes * recording update & code owner update * analyzer fix * update code owner for sms Co-authored-by: Petr Švihlík <rocky.intel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists