Skip to content

Add test::CommonOptions::evmDialect method#15618

Merged
cameel merged 1 commit intodevelopfrom
test-common-options-evmdialect-method
Dec 9, 2024
Merged

Add test::CommonOptions::evmDialect method#15618
cameel merged 1 commit intodevelopfrom
test-common-options-evmdialect-method

Conversation

@clonker
Copy link
Member

@clonker clonker commented Dec 6, 2024

to replace the

auto const& dialect = EVMDialect::strictAssemblyForEVMObjects(
    solidity::test::CommonOptions::get().evmVersion(),
    solidity::test::CommonOptions::get().eofVersion()
);

pattern.

Follow-up of PR #15347

@clonker clonker added has dependencies The PR depends on other PRs that must be merged first refactor labels Dec 6, 2024
cameel
cameel previously approved these changes Dec 6, 2024
@clonker clonker force-pushed the builtin_ast_element branch 2 times, most recently from fca7d33 to 8994d85 Compare December 9, 2024 07:37
@clonker clonker force-pushed the test-common-options-evmdialect-method branch from eb8b5c9 to 62bf89e Compare December 9, 2024 07:47
Base automatically changed from builtin_ast_element to develop December 9, 2024 14:07
@clonker clonker dismissed cameel’s stale review December 9, 2024 14:07

The base branch was changed.

@cameel cameel force-pushed the test-common-options-evmdialect-method branch from 62bf89e to b1f9211 Compare December 9, 2024 18:56
@cameel cameel removed the has dependencies The PR depends on other PRs that must be merged first label Dec 9, 2024
@cameel cameel force-pushed the test-common-options-evmdialect-method branch from b1f9211 to a26b281 Compare December 9, 2024 21:14
@cameel cameel enabled auto-merge December 9, 2024 21:15
@cameel cameel merged commit 643a18e into develop Dec 9, 2024
@cameel cameel deleted the test-common-options-evmdialect-method branch December 9, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants