Fix missing std:: prefix for PROFILE_OPTIMIZER_STEPS#15465
Merged
nikola-matic merged 1 commit intodevelopfrom Sep 30, 2024
Merged
Fix missing std:: prefix for PROFILE_OPTIMIZER_STEPS#15465nikola-matic merged 1 commit intodevelopfrom
std:: prefix for PROFILE_OPTIMIZER_STEPS#15465nikola-matic merged 1 commit intodevelopfrom
Conversation
nikola-matic
approved these changes
Sep 30, 2024
Collaborator
Author
|
The reason why I noticed it in the first place is that I wanted to see what is taking the most time in the optimizer now, especially on full projects. I think we only ever ran it on single contracts. Here's what I got. This is on top of #15451, which is what we'll release as 0.8.28 soon. Note that these are cumulative results over all contracts in a project. Normally the profiler prints the results separately for each contract, but I made OpenZeppelin
Uniswap
Eigenlayer
Comparison
|
47b2f77 to
146e2bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the profiling we have for optimizer steps in
Suite.cppbroke with the removalofusing namespace std. This is a trivial fix to add thestd::prefix.Note that we never build in CI with
-DPROFILE_OPTIMIZER_STEPS, so CI will pass here regardless of whether it's broken or not.