Stop caching outputs with LazyInit in CompilerStack#15459
Closed
cameel wants to merge 1 commit intocompiler-stack-do-not-store-serialized-jsonfrom
Closed
Stop caching outputs with LazyInit in CompilerStack#15459cameel wants to merge 1 commit intocompiler-stack-do-not-store-serialized-jsonfrom
LazyInit in CompilerStack#15459cameel wants to merge 1 commit intocompiler-stack-do-not-store-serialized-jsonfrom
Conversation
cameel
added
performance 🐎
has dependencies
Collaborator
Author
BenchmarksResults from
Looks like timing is the same. Memory use did fall a little on legacy, but on IR is practically unaffected. The only field that's legacy-only are generated sources, so it seems that it's just those that are worth getting rid of. |
Collaborator
Author
|
Closing in favor of #15460. Looks like all the gains here are indeed due to generated sources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #15451.
This is a follow-up to #15451, removing more of the data cached in
CompilerStack:metadata,abi,storageLayout,transientStorageLayout,userDocumentation,devDocumentation,generatedSourcesandruntimeGeneratedSourcesare now always generated on demand.This is a test PR to benchmark it see if it's even worth it.
If it's going to be merged, we should perhaps check if some of these aren't used a lot internally and better off cached after all.