Yul: Remove boolType and defaultType from dialect#15332
Merged
Conversation
clonker
force-pushed
the
remove_yul_dialect_types
branch
from
eafd149 to
b6c34dc
Compare
aarlt
previously approved these changes
Aug 14, 2024
clonker
force-pushed
the
remove_yul_dialect_types
branch
from
66004ee to
a0e8b02
Compare
clonker
force-pushed
the
remove_yul_dialect_types
branch
2 times, most recently
from
7c40424 to
6b6972e
Compare
aarlt
reviewed
Aug 15, 2024
clonker
force-pushed
the
remove_yul_dialect_types
branch
from
6b6972e to
c2ae2e2
Compare
aarlt
reviewed
Aug 15, 2024
aarlt
reviewed
Aug 15, 2024
aarlt
previously approved these changes
Aug 15, 2024
Contributor
aarlt
left a comment
aarlt
left a comment
There was a problem hiding this comment.
LGTM! I just left some general questions about other related things.
ekpyron
reviewed
Aug 15, 2024
clonker
force-pushed
the
remove_yul_dialect_types
branch
3 times, most recently
from
d62ce08 to
1890a67
Compare
cameel
reviewed
Aug 26, 2024
Collaborator
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
Looks good, only needs a few small tweaks and it will be ready to go.
clonker
force-pushed
the
remove_yul_dialect_types
branch
2 times, most recently
from
d73a5bf to
ec2536e
Compare
cameel
previously approved these changes
Aug 27, 2024
clonker
force-pushed
the
remove_yul_dialect_types
branch
from
ec2536e to
03b01c1
Compare
…e vectors of types
clonker
force-pushed
the
remove_yul_dialect_types
branch
from
03b01c1 to
4938075
Compare
cameel
approved these changes
Aug 28, 2024
1 task
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.