Optimization without dependencies in CompilerStack#15230
Closed
cameel wants to merge 10 commits intomodular-ir-generator-outputfrom
Closed
Optimization without dependencies in CompilerStack#15230cameel wants to merge 10 commits intomodular-ir-generator-outputfrom
CompilerStack#15230cameel wants to merge 10 commits intomodular-ir-generator-outputfrom
Conversation
…ther than YulStack
… objects into account any more
Collaborator
Author
|
Just like in case of #15182, closing because we won't be merging it. The actual fix is based on caching optimized IR instead. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15179.
Depends on #15229.
Replaces/closes #15182.
Includes commits from #15228.
This PR builds on the refactor from #15229, making
CompilerStackactually take advantage of the new structure.IRGeneratorOutputcan now be parsed into a partial YulObjectthat does not contain dependencies and can also be optimized in this form.What we have here should already be good enough for #15179, but it we wanted to, we could go one step further and extend it to reusing EVM assemblies, avoiding repeating the Yul->EVM transform.
Status
Mostly done in terms of functionality. Needs resolving a few final snags, some cleanup and testing.
Objects, without serializing and reparsing them?