Generating IR without dependencies included#15224
Closed
Conversation
cameel
force-pushed
the
generating-ir-without-dependencies-included
branch
from
c4876e5 to
9399332
Compare
cameel
force-pushed
the
generating-ir-without-dependencies-included
branch
from
9399332 to
e95e533
Compare
Collaborator
Author
|
Closing in favor of #15229. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first part of refactor for #15179.
Introduces
ObjectSourceobject that can store partial IR output (without the sources of dependent contracts). Then makesIRGeneratoroutput it. FinallyCompilerStackputs it together into a complete IR source file.Status
Works but still needs some tweaks.
It compiles and gives the same results as the original codegen, but I want to do some final changes to the structure and also fill in small things that I skipped on the first pass (constructors, docstrings, etc.). The remaining stuff is marked with
TMPnotes.The next step will be passing
ObjectSourcedirectly toYulStackand making it handle incompleteObjects. This will make the compiler reuse optimized IR