Skip to content

Remove redundant prerequisite steps from the default optimizer sequence#15092

Merged
cameel merged 1 commit intodevelopfrom
remove-redundant-prerequisites-from-default-sequence
Jan 19, 2026
Merged

Remove redundant prerequisite steps from the default optimizer sequence#15092
cameel merged 1 commit intodevelopfrom
remove-redundant-prerequisites-from-default-sequence

Conversation

@cameel
Copy link
Collaborator

@cameel cameel commented May 11, 2024

Since gho steps are hard-coded as prerequisites, there's not much point in having them in the default sequence. All other steps are supposed to preserve these properties.

For now this is just to verify that removing them does not really change generated bytecode in a meaningful way.

If this is true, we might consider merging it, though that would probably be better done only after rebasing it on the new sequence (#15030). Otherwise merging it would just revert it.

@cameel cameel self-assigned this May 11, 2024
@cameel cameel force-pushed the remove-redundant-prerequisites-from-default-sequence branch from 80c293d to 1462e34 Compare May 13, 2024 17:14
@cameel
Copy link
Collaborator Author

cameel commented May 13, 2024

Rebased on top of the new sequence.

Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the docs with this new default sequence, right? I guess we mention it there.

@cameel
Copy link
Collaborator Author

cameel commented May 15, 2024

No, we don't really document the default sequence.

We need a changelog entry though.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label May 30, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label May 30, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jun 14, 2024
@argotorg argotorg deleted a comment from github-actions bot Jun 14, 2024
@r0qs r0qs removed the stale The issue/PR was marked as stale because it has been open for too long. label Jun 14, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jun 29, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jun 30, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jul 14, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jul 15, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jul 29, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jul 30, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 13, 2024
@ekpyron ekpyron removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 15, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 30, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 31, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Sep 15, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Sep 16, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 1, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 1, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 16, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 17, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 1, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Nov 1, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 16, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Apr 2, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Apr 2, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Apr 17, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Apr 17, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label May 2, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label May 2, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label May 17, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label May 18, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jun 1, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jun 4, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jun 18, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jun 19, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jul 4, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jul 5, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jul 20, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jul 20, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 4, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 4, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 19, 2025
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 19, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Sep 3, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Sep 8, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Sep 23, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Sep 24, 2025
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 9, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 15, 2025
@cameel
Copy link
Collaborator Author

cameel commented Jan 14, 2026

This is now ready to be merged. Originally I wanted to do some more testing here to be absolutely sure this does not break anything, but since there are absolutely zero changes in test expectations, I guess I was being too cautious. Conceptually this is just a refactor that should have no user-visible effects, because these steps are still there, before the main sequence.

Copy link
Contributor

@rodiazet rodiazet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some questions added to clarify.

Language Features:

Compiler Features:
* Yul Optimizer: Remove redundant prerequisite steps from the default optimizer sequence.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we name them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't because I did not think it was all that relevant to the user. If you do not use a custom sequence, you do not have to do anything. If you do and want to have the default sequence with just some modifications, you have to look at the diff anyway. We do not document the exact shape of the default sequence anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants