You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since gho steps are hard-coded as prerequisites, there's not much point in having them in the default sequence. All other steps are supposed to preserve these properties.
For now this is just to verify that removing them does not really change generated bytecode in a meaningful way.
If this is true, we might consider merging it, though that would probably be better done only after rebasing it on the new sequence (#15030). Otherwise merging it would just revert it.
This is now ready to be merged. Originally I wanted to do some more testing here to be absolutely sure this does not break anything, but since there are absolutely zero changes in test expectations, I guess I was being too cautious. Conceptually this is just a refactor that should have no user-visible effects, because these steps are still there, before the main sequence.
The reason will be displayed to describe this comment to others. Learn more.
I didn't because I did not think it was all that relevant to the user. If you do not use a custom sequence, you do not have to do anything. If you do and want to have the default sequence with just some modifications, you have to look at the diff anyway. We do not document the exact shape of the default sequence anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
ghosteps are hard-coded as prerequisites, there's not much point in having them in the default sequence. All other steps are supposed to preserve these properties.For now this is just to verify that removing them does not really change generated bytecode in a meaningful way.
If this is true, we might consider merging it, though that would probably be better done only after rebasing it on the new sequence (#15030). Otherwise merging it would just revert it.