Skip to content

Fix hardhat tests to use cancun hardfork#14933

Merged
cameel merged 0 commit intomakeCancunDefaultfrom
fix-hardhat-tests-cancun
Mar 13, 2024
Merged

Fix hardhat tests to use cancun hardfork#14933
cameel merged 0 commit intomakeCancunDefaultfrom
fix-hardhat-tests-cancun

Conversation

@r0qs
Copy link
Member

@r0qs r0qs commented Mar 13, 2024

No description provided.

cameel
cameel previously approved these changes Mar 13, 2024
@r0qs r0qs added the has dependencies The PR depends on other PRs that must be merged first label Mar 13, 2024
@r0qs r0qs force-pushed the fix-hardhat-tests-cancun branch from 1bbf641 to 97a432e Compare March 13, 2024 13:42
@r0qs r0qs force-pushed the makeCancunDefault branch from 59b3530 to 8921505 Compare March 13, 2024 13:43
@r0qs r0qs force-pushed the fix-hardhat-tests-cancun branch from 97a432e to c8e64e3 Compare March 13, 2024 13:44
@cameel
Copy link
Collaborator

cameel commented Mar 13, 2024

So, is this ready? I see Hardhat tests passed here. If so, please rebase on develop so that we can merge it.

@nikola-matic nikola-matic force-pushed the fix-hardhat-tests-cancun branch from c8e64e3 to 1221a70 Compare March 13, 2024 21:17
@nikola-matic nikola-matic force-pushed the fix-hardhat-tests-cancun branch from 1221a70 to 131b9d8 Compare March 13, 2024 21:18
@cameel cameel changed the base branch from makeCancunDefault to develop March 13, 2024 21:46
@cameel cameel dismissed their stale review March 13, 2024 21:46

The base branch was changed.

@cameel cameel changed the base branch from develop to makeCancunDefault March 13, 2024 22:08
@nikola-matic nikola-matic changed the base branch from makeCancunDefault to develop March 13, 2024 22:16
@nikola-matic nikola-matic force-pushed the fix-hardhat-tests-cancun branch from 131b9d8 to e5c8897 Compare March 13, 2024 22:17
@nikola-matic nikola-matic changed the base branch from develop to makeCancunDefault March 13, 2024 22:21
@cameel cameel merged commit fbeef89 into makeCancunDefault Mar 13, 2024
@cameel cameel force-pushed the makeCancunDefault branch from a0d7615 to a388ccb Compare March 13, 2024 22:27
@cameel cameel deleted the fix-hardhat-tests-cancun branch March 13, 2024 22:27
@cameel cameel force-pushed the fix-hardhat-tests-cancun branch from e5c8897 to fbeef89 Compare March 13, 2024 22:27
@cameel cameel restored the fix-hardhat-tests-cancun branch March 13, 2024 22:27
@cameel cameel deleted the fix-hardhat-tests-cancun branch March 13, 2024 22:28
@cameel
Copy link
Collaborator

cameel commented Mar 13, 2024

Argh. I wanted to merge this first and then #14907 on top of it but github just closed the PR when I switched their order.

@cameel cameel removed the has dependencies The PR depends on other PRs that must be merged first label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants