Convert disabled external tests to compile-only#14916
Merged
Conversation
This way we can still get bytecode size benchmarks for them
Collaborator
Author
r0qs
reviewed
Mar 7, 2024
r0qs
reviewed
Mar 7, 2024
r0qs
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the disabled external tests seem to still compile fine, at most with some minor adjustments. It's only the test suite that is broken. They're still useful for bytecode size benchmarks so I'd like to re-enabled them in a compile-only mode. That would give us more relevant data points for evaluating changes to the optimizer sequence (#14406).