Nested brackets in optimizer

[v-sreekesh]

Fixes #11809.
Depends on #12098. Draft until that PR is merged.

[cameel]

Thanks for the PR @v-sreekesh!

Here is some feedback from me. I have a suggestion on how to approach the implementation and also some hints on how to match our style.

One other suggestion would be to put Fixes #11809 in the first comment of the PR. This way github will know that it can close the original issue once we merge the PR.

Also, please take a look at the CI results. There are compilation errors there. You'll need to fix them to make the PR mergeable. Let me know if you have any problems dealing with them.

[cameel]

Still needs some work but you're going in a good direction.

If you want to check if your changes to validation are correct, please run test/cmdlineTests.sh. It has some tests covering it already but you should also add some more and also update expectations in existing tests. For example yul_optimizer_steps_invalid_nesting should no longer expect an error after your changes.

[cameel]

@v-sreekesh How is it going with the implementation? Do you need any help?

[v-sreekesh]

@v-sreekesh How is it going with the implementation? Do you need any help?

Hi @cameel i was out of station from last two weeks will be working on this by this weekend i will let you know if i need any help thanks

[cameel]

This is now fully implemented and ready for review.

I did some test cleanup to make the changes the feature introduces easier to see. That's in #12098 and needs to be merged before this PR.

[chriseth]

Weird, why was this closed? I just merged the other PR...
I'm not able to re-open this, so created a new PR: #12102

[cameel]

I've had this happen before. Github for some reason closes external PRs based on another branch. Maybe it's because merging the base PR deletes the branch and github can't change base to develop because the latest commits from develop do not exist in the external repo? In any case this pretty inconvenient on github's part.