Conversation
8 tasks
blishko
reviewed
Sep 24, 2025
Collaborator
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
Looks good!
I did not find any mention about adding foldl' to Prelude in the GHC changelog.
Is there a difference between Foldable in Prelude and Data.Foldable?
Can we just use the Prelude one?
Collaborator
Author
|
@blishko see https://discourse.haskell.org/t/prelude-foldl-migration-guide/6950 We cannot use just the Prelude one right now as build with older base/GHC combos would break. Once we're comfortable supporting GHC >=9.10 only we can clean up the imports a bit. |
See this post for rationale: https://kseo.github.io/posts/2016-12-21-foldl-vs-foldl%27.html
Collaborator
|
LGTM. Do you wanna merge? |
Collaborator
Author
|
If you're all ok with it, let's merge these changes so we're ready to make the switch to 9.10 sometime in the future. |
Collaborator
|
Sure, merged! Thanks a lot :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes warnings that appear when building with GHC 9.10, due to
foldl'now being available on prelude as well.Checklist