Skip to content

using -Wunused-packages to eliminate unused deps#518

Merged
msooseth merged 4 commits intoargotorg:mainfrom
hellwolf:warn-unused-packages
Aug 1, 2024
Merged

using -Wunused-packages to eliminate unused deps#518
msooseth merged 4 commits intoargotorg:mainfrom
hellwolf:warn-unused-packages

Conversation

@hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Jul 31, 2024

Description

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@hellwolf
Copy link
Contributor Author

hellwolf commented Jul 31, 2024

  • Local build test: cabal build --enable-tests --enable-benchmarks all
  • One warning left due to a bug in ghc:
    <no location info>: warning: [GHC-42258] [-Wunused-packages]
        The following packages were specified via -package or -package-id flags,
        but were not needed for compilation:
          - system-cxx-std-lib-1.0 (exposed by flag -package-id system-cxx-std-lib-1.0)
    

@hellwolf hellwolf marked this pull request as draft July 31, 2024 21:05
@hellwolf hellwolf marked this pull request as ready for review July 31, 2024 21:35
@hellwolf hellwolf mentioned this pull request Jul 31, 2024
4 tasks
@msooseth msooseth merged commit cad8b5c into argotorg:main Aug 1, 2024
@msooseth
Copy link
Collaborator

msooseth commented Aug 1, 2024

NICE, so much cleaner! Thanks so much!

@hellwolf hellwolf deleted the warn-unused-packages branch August 1, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants