Conversation
On arm Mac, the GHC is trying to locate libc++, but during that it also searches for c++ (without the lib prefix), which is an alias for a clang executable. It tries to load an executable as a static library which results in an error. I have no idea why these changes work, but they seem to work.
Foundry does not depend on DS tests anymore, they provide their own cheatcodes directly in their VM now, so that the `lib` directory no longer exists.
This shell only sets up the test dependencies, but keeps the Haskell environment setup from the system. This is a temporary workaround until the nix/ghc issue on MacOS is fixed upstream.
|
Let me know when this is ready for review! :) I'd be happy to review & merge. |
hevm.cabal
Outdated
| if os(linux) | ||
| build-depends: system-cxx-std-lib | ||
| elif !os(darwin) | ||
| extra-libraries: stdc++ |
There was a problem hiding this comment.
I think we may be able to simplify this now and just have build-depends: system-cxx-std-lib for all platforms, plus the special darwin flags just in one place.
There was a problem hiding this comment.
@elopez , do you want to try it?
There are already 4 people contributing to this PR, why not make it 5 😄
There was a problem hiding this comment.
sure, I don't have push access here, but here it is:
elopez@653805f
elopez@da293e8
CI run: https://github.com/elopez/hevm/actions/runs/10076828902/job/27858016218?pr=4
There was a problem hiding this comment.
Your commits are included. First, there was some problem in CI, but after restarting a job, everything is green now!
|
@d-xo, I guess we can merge now, WDYT? |
|
@blishko there's one last issue remaining, the redistributable files produced by nix contain references to the nix store due to how c++ / c++abi is now split. I'm hoping this fixes it and prevents the issue from going unnoticed again elopez@6575b73 Edit: it seems to work fine locally. The build CI uploads "nixful" binaries but that's because it doesn't use #redistributable. I expect the release CI to work fine with that patch. |
|
@elopez thats not a regression and I think it can be fixed in a separate pr. Let's merge this now. thanks for the work everyone,I think we have commits from almost every active hevm contributor on this branch ❤️ |
5 participants
Description
This finishes the work started in #471.
Checklist