Conversation
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
Hi and thanks :) I just had a few questions, I thought I'd share! Let me know what you think,
Mate
|
Right now the purpose is mainly to get a PR open so work isn't duplicated. Maybe I could separate out the |
|
Thanks! Would be v happy to merge the bench.hs changes. Would be great if we would start building this in ci too. |
bench/bench.hs
Outdated
| case result of | ||
| Left _ -> pure False | ||
| Right _ -> pure True | ||
| -- maybeReason <- BCTests.checkExpectation False x (_ result) |
There was a problem hiding this comment.
is this no longer needed? can we remove commented lines?
There was a problem hiding this comment.
I was not sure if this is a good replacement. @d-xo what do you think?
There was a problem hiding this comment.
I don't think this is a good replacement. checkExpectation is comparing various parts of the state to the expected results defined in the blockchain tests, this new code is just checking if the execution was succesful or not....
| sha256 = "sha256-wzZ/64G7nVAzIFjKNs/jBvv6gQdTIQS4X/OvM5KWfnU="; | ||
| } + "/indexed-profunctors") {}); | ||
| # use obsidian systems fork of string-qq | ||
| string-qq = self.callCabal2nix "string-qq" (pkgs.fetchFromGitHub { |
There was a problem hiding this comment.
can we upstream this to nixpkgs?
There was a problem hiding this comment.
Sure, I'll make a PR to Nixpkgs explaining the situation with string-qq
| patchedHaskellPackages = pkgs.haskell.packages.ghc94.override { | ||
| overrides = self: super: { | ||
| # disable tests in optics | ||
| optics-core = pkgs.haskell.lib.dontCheck (self.callCabal2nix "optics-core" (pkgs.fetchFromGitHub { |
There was a problem hiding this comment.
This will be included in the next bump right?
There was a problem hiding this comment.
Yes, when the nexthaskell-updates is merged after NixOS/nixpkgs#236431
|
Can this be closed now we have #303 ? |
|
Closing. |
4 participants
Description
Work in progress for GHC 9.4 support. Includes temporary overrides for optics and other packages in the flake. Testing is being performed on
aarch64-darwinChecklist