-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SubjectAltName into certificate #28
base: master
Are you sure you want to change the base?
Conversation
Hi @zt2 thanks for the PR. Unfortunately the test pipeline in circleci doesn't seem to be working (I'm not actively maintaining this project TBH). It seems there're some linting errors with your changes. Can you please run |
Hi @argos83, sorry for reply later, I can pass 'bundle exec rspec' in my environment (too many deprecated warnings).
My Ruby version is |
@@ -20,7 +20,7 @@ def self.create(common_name, serial_number: nil) | |||
cert.subject.country = 'AR' | |||
cert.not_before = cert.not_before - 3600 * 24 * 30 # Substract 30 days | |||
cert.serial_number.number = serial_number || common_name.hash.abs | |||
cert.key_material.generate_key(1024) | |||
cert.key_material.generate_key(4096) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix ERR_CERT_WEAK_KEY error from browser
extensions['extensions']['subjectAltName'] = { | ||
'dns_names' => [servername], | ||
'uris' => [servername] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix "Subject Alternative Name Missing" in browser
@https = Ritm::Proxy::SSLReverseProxy.new(@conf.ssl_reverse_proxy.bind_address, | ||
@conf.ssl_reverse_proxy.bind_port, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow access from the device in the same network, this is useful when you need to inception HTTPS between an iOS app and a remote server.
Feature:
Fix: