Tolerate missing isIncognito method in Puppeteer v23 #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to include some additional checks to close the browser context for if the |
I didn't dig too deeply into why the context is only closed here for incognito in the first place! Was trying to fix this without much ... er ... context :) |
|
Thanks, closed in favor of #588 |
rochejul
added a commit
to rochejul/web-component-attribute-polyfill
that referenced
this pull request
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #586
Summary
Upgrading to Puppeteer v23 breaks tests since the isIncognito method has been removed. See https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v23.0.0
puppeteer/puppeteer#12830
Test plan
Make change in an environment that uses Puppeteer v23. Tests no longer fail.