feat: return images from resources when sync occurs #642
Conversation
Aaron-9900
force-pushed
the
feat/add-images-to-resources
branch
from
922aecd to
3f1734a
Compare
Aaron-9900
changed the title
Aaron-9900
force-pushed
the
feat/add-images-to-resources
branch
from
5281e57 to
ae4000b
Compare
pkg/utils/kube/kube.go
Outdated
| for _, container := range containers { | ||
| containerMap, ok := container.(map[string]interface{}) | ||
| if !ok { | ||
| return nil |
There was a problem hiding this comment.
Should we continue instead of returning here? It might be something related to the single container only
There was a problem hiding this comment.
Makes sense to extract as much data as possible. Added continue on 5b2c46f but maybe @andrii-korotkov-verkada has a different take
| @@ -404,6 +404,34 @@ func GetDeploymentReplicas(u *unstructured.Unstructured) *int64 { | |||
| return &val | |||
| } | |||
|
|
|||
| func GetResourceImages(u *unstructured.Unstructured) []string { | |||
There was a problem hiding this comment.
For CronJobs it seems that the image is under spec.jobTemplate.spec.template.spec.containers. Should we also check there?
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #642 +/- ##
==========================================
- Coverage 54.26% 53.50% -0.76%
==========================================
Files 64 64
Lines 6164 6442 +278
==========================================
+ Hits 3345 3447 +102
- Misses 2549 2717 +168
- Partials 270 278 +8 ☔ View full report in Codecov by Sentry. |
Aaron-9900
force-pushed
the
feat/add-images-to-resources
branch
3 times, most recently
from
50c907f to
a989b44
Compare
Signed-off-by: Aaron Hoffman <[email protected]>
Signed-off-by: Aaron Hoffman <[email protected]>
Signed-off-by: Aaron Hoffman <[email protected]>
Signed-off-by: Aaron Hoffman <[email protected]>
…for cronjobs Signed-off-by: Aaron Hoffman <[email protected]>
Signed-off-by: Aaron Hoffman <[email protected]>
Signed-off-by: Aaron Hoffman <[email protected]>
Aaron-9900
force-pushed
the
feat/add-images-to-resources
branch
from
a989b44 to
e6f8fbe
Compare
|
Implementing the Gitops side of this issue: argoproj/argo-cd#20896
Adds an api to
kube.goto get the images from a resource. Adds those images toResourceSyncResult. This API accounts for how different k8s resources define the images.