Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable consumers of gitops-engine API to specify an alternative temp directory for generated manifests, as an alternative '/dev/shm' #613

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jul 17, 2024

See parent issue for details: #614

This PR:

  • When calling gitops-engine, you will now need to explicitly define the temporary path to write kubectl manifests to:
    • Add new parameter tmpManifestPath to public APIs:
      • NewEngine in pkg/engine/engine.go
      • NewClusterCache in `pkg/cache/cluster.go
    • In both cases, when calling these functions, you now must specify where to store temporary manifest files that are generated
    • If you wish to preserve the existing behaviour, just use the value from calling io.TempPathUseDevShmIfAvailable() (see examples in this PR)
  • Updates existing gitops-engine code to use new API
  • Preserves the existing behaviour of the code: code and tests that were previously using /dev/shm will continue to do so
  • Updates pkg/utils/io/io.go API to make it more explicit about behaviour

@jgwest jgwest force-pushed the customize-manifest-store-path-may-2024 branch 2 times, most recently from d002f02 to a88f580 Compare July 17, 2024 11:55
@jgwest jgwest changed the title Enable consumers of gitops-engine API to specify an alternative temp directory to '/dev/shm', for generated manifests Enable consumers of gitops-engine API to specify an alternative temp directory for generated manifests, as an alternative '/dev/shm' Jul 18, 2024
@jgwest jgwest force-pushed the customize-manifest-store-path-may-2024 branch from a88f580 to 73c025b Compare July 26, 2024 20:41
Copy link

sonarcloud bot commented Jul 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant