This repository was archived by the owner on Dec 17, 2025. It is now read-only.
fix: printing gvkparser error message#585
Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom Jun 25, 2024
Merged
Conversation
The log.Info function doesn't understand format directives, so use key/value to print error message. Signed-off-by: Paul Gier <paul.gier@datastax.com>
|
crenshaw-dev
changed the title
crenshaw-dev
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The log.Info function doesn't understand format directives, so use key/value to print error message.
Related PR which caused the error to be hidden: #430
I'm not sure if this should stay at Info level or if it was correct previously at error level because this is a real issue. The failed gvkParser seems to be the cause of inaccurate diffs: #18213