Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce k8s.io/kubernetes usage #57

Merged
merged 1 commit into from
Jun 10, 2020
Merged

refactor: reduce k8s.io/kubernetes usage #57

merged 1 commit into from
Jun 10, 2020

Conversation

ash2k
Copy link
Member

@ash2k ash2k commented Jun 10, 2020

See #56.

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ash2k ash2k mentioned this pull request Jun 10, 2020
Open
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   52.49%   52.49%           
=======================================
  Files          25       25           
  Lines        2585     2585           
=======================================
  Hits         1357     1357           
  Misses       1100     1100           
  Partials      128      128
Impacted Files Coverage Δ
pkg/diff/diff.go 59.63% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16575f1...b09de01. Read the comment docs.

@alexmt alexmt changed the title Reduce k8s.io/kubernetes usage refactor: reduce k8s.io/kubernetes usage Jun 10, 2020
alexmt
alexmt approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @ash2k !

@alexmt alexmt merged commit 5622a64 into argoproj:master Jun 10, 2020
@ash2k ash2k deleted the ash2k/reduce-k8s.io-kubernetes-usage branch June 11, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ash2k @alexmt