Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

fix: Set QPS and burst rate for resource ops client#395

Merged
jannfis merged 1 commit intoargoproj:masterfrom
jannfis:fix/qps-and-burst-for-resource-ops
Mar 28, 2022
Merged

fix: Set QPS and burst rate for resource ops client#395
jannfis merged 1 commit intoargoproj:masterfrom
jannfis:fix/qps-and-burst-for-resource-ops

Conversation

@jannfis
Copy link
Member

@jannfis jannfis commented Mar 28, 2022

This allows to set Kubernetes client QPS and burst rates for the resource ops client, according to the configuration of the client.

Needs a very small change in Argo CD as well, which will be submitted separately.

Supersedes #349

Signed-off-by: jannfis jann@mistrust.net

Signed-off-by: jannfis <jann@mistrust.net>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #395 (040d412) into master (723667d) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   54.27%   54.23%   -0.04%     
==========================================
  Files          41       41              
  Lines        3053     3055       +2     
==========================================
  Hits         1657     1657              
- Misses       1233     1235       +2     
  Partials      163      163              
Impacted Files Coverage Δ
pkg/utils/kube/ctl.go 5.63% <0.00%> (ø)
pkg/utils/kube/resource_ops.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723667d...040d412. Read the comment docs.

@jannfis jannfis merged commit 73bcea9 into argoproj:master Mar 28, 2022
jannfis added a commit that referenced this pull request Mar 28, 2022
Signed-off-by: jannfis <jann@mistrust.net>
@jannfis
Copy link
Member Author

jannfis commented Mar 28, 2022

Cherry-picked into release-0.6: 1a7a69f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants