Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

feat: get app name by annotation#328

Closed
pasha-codefresh wants to merge 3 commits intoargoproj:masterfrom
pasha-codefresh:get-app-instance-annotation
Closed

feat: get app name by annotation#328
pasha-codefresh wants to merge 3 commits intoargoproj:masterfrom
pasha-codefresh:get-app-instance-annotation

Conversation

@pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Sep 17, 2021

@pasha-codefresh pasha-codefresh changed the title get app name by annotation feat :get app name by annotation Sep 17, 2021
@pasha-codefresh pasha-codefresh changed the title feat :get app name by annotation feat: get app name by annotation Sep 17, 2021
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh force-pushed the get-app-instance-annotation branch from e7e4c09 to 756d8e1 Compare September 17, 2021 20:09
@pasha-codefresh pasha-codefresh added the enhancement New feature or request label Sep 17, 2021
@pasha-codefresh pasha-codefresh force-pushed the get-app-instance-annotation branch from 5ae3f9d to 12e7686 Compare September 17, 2021 20:14
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #328 (e7e4c09) into master (a4c77d5) will increase coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head e7e4c09 differs from pull request most recent head 12e7686. Consider uploading reports for the commit 12e7686 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   48.51%   48.56%   +0.05%     
==========================================
  Files          41       41              
  Lines        3306     3317      +11     
==========================================
+ Hits         1604     1611       +7     
- Misses       1543     1547       +4     
  Partials      159      159              
Impacted Files Coverage Δ
pkg/utils/kube/kube.go 33.91% <0.00%> (-0.61%) ⬇️
pkg/utils/kube/resource_ops.go 0.00% <0.00%> (ø)
pkg/sync/sync_tasks.go 91.66% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c77d5...12e7686. Read the comment docs.

Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh force-pushed the get-app-instance-annotation branch from 12e7686 to 84c49a5 Compare September 17, 2021 20:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pasha-codefresh pasha-codefresh deleted the get-app-instance-annotation branch September 17, 2021 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant