Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade python openapiclient version, fixes #9770 #9840

Merged
merged 2 commits into from
Oct 21, 2022
Merged

fix: upgrade python openapiclient version, fixes #9770 #9840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6784b4f
fix: upgrade openapiclient, fix python api
tczhao Oct 16, 2022
56b1eaa
fix: roll back apiclient for java version change
tczhao Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 3 additions & 1 deletion .github/workflows/ci-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@ jobs:
sudo find /usr/local/include -type f | xargs sudo chmod a+r
sudo find /usr/local/include -type d | xargs sudo chmod a+rx
ls /usr/local/include/google/protobuf/
- run: docker pull openapitools/openapi-generator-cli:v5.2.1 &
- run: |
docker pull openapitools/openapi-generator-cli:v5.4.0 &
docker pull openapitools/openapi-generator-cli:v5.2.1 &
Comment on lines +177 to +178
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we pulling two versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python gen is upgraded to v5.4.0
Java gen is facing some issues in v5.4.0, unchanged for now, remain at 5.2.1

- name: Create links
run: |
mkdir -p /home/runner/go/src/github.com/argoproj
Expand Down
2 changes: 1 addition & 1 deletion sdks/python/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ generate:
sed 's/io.k8s.apimachinery.pkg.apis.meta.v1.//' \
> $(WD)/swagger.json
cp ../../LICENSE $(WD)/LICENSE
$(DOCKER) openapitools/openapi-generator-cli:v5.2.1 \
$(DOCKER) openapitools/openapi-generator-cli:v5.4.0 \
generate \
--input-spec /wd/swagger.json \
--generator-name python \
Expand Down
1,073 changes: 572 additions & 501 deletions sdks/python/client/argo_workflows/api/archived_workflow_service_api.py
View file
Open in desktop

Large diffs are not rendered by default.

Loading