Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid nil pointer dereference. Fixes #9269 #9787

Merged
merged 1 commit into from
Oct 11, 2022
Merged

fix: avoid nil pointer dereference. Fixes #9269 #9787

merged 1 commit into from
Oct 11, 2022

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Oct 11, 2022 •
edited
Loading

Signed-off-by: mikutas [email protected]

Fixes #9269

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@mikutas mikutas changed the title fix: avoid nil pointer dereference fix: avoid nil pointer dereference. Fixes #9269 Oct 11, 2022
@mikutas mikutas marked this pull request as ready for review October 11, 2022 07:50
@alexec alexec merged commit 0fc883a into argoproj:master Oct 11, 2022
@mikutas mikutas deleted the 9269 branch October 11, 2022 23:33
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
@mikutas @juchaosong
fix: avoid nil pointer dereference. Fixes argoproj#9269 (argoproj#9787)
2d4c075 
Signed-off-by: mikutas <[email protected]>
Signed-off-by: juchao <[email protected]>
@sarabala1979 sarabala1979 mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: runtime error: invalid memory address or nil pointer dereference (3.3.8)
2 participants
@mikutas @alexec