fix: Support Kubernetes v1.24. Fixes #8320 #9620

alexec · 2022-09-19T22:32:38Z

Signed-off-by: Alex Collins [email protected]

Fixes #8320

Changes:

Update Github Actions to use a good looking action for K3S, running latest K3S.
Reduced build time by 3m.
Added diagnostics to builds.

terrytangyuan · 2022-09-25T00:43:33Z

Will continue the work in #9680

docs/manually-create-secrets.md

alexec · 2022-10-14T23:20:14Z

We're getting close!

docs/manually-create-secrets.md

.github/workflows/ci-build.yaml

manifests/quick-start/mysql/mysql-deployment.yaml

Signed-off-by: Alex Collins <[email protected]>

manifests/quick-start/mysql/mysql-deployment.yaml

Signed-off-by: Alex Collins <[email protected]>

alexec · 2022-10-15T15:27:38Z

Phew. That was epic.

terrytangyuan

Thanks! LGTM overall. Just a couple of small comments. We should also test this to make sure it still works in older versions of k8s.

docs/manually-create-secrets.md

.github/workflows/ci-build.yaml

Signed-off-by: Alex Collins <[email protected]>

alexec · 2022-10-16T15:42:34Z

.github/workflows/ci-build.yaml

@@ -59,7 +59,7 @@ jobs:
    name: E2E Tests
    runs-on: ubuntu-latest
    timeout-minutes: 25
-    needs: [ tests, argoexec-image ]
+    needs: [ argoexec-image ]


argoexec-image is 3m faster than tests, so this speeds up the build by 3m

alexec · 2022-10-16T15:43:03Z

hack/free-port.sh


 port=$1

-lsof -s TCP:LISTEN -i ":$port" | grep -v PID | awk '{print $2}' | xargs -L 1 kill || true
+pids=$(lsof -t -s TCP:LISTEN -i ":$port" || true)


this wrote a lot of errors on linux

M .github/workflows/ci-build.yaml M hack/free-port.sh Signed-off-by: Alex Collins <[email protected]>

Signed-off-by: Alex Collins <[email protected]>

alexec · 2022-10-17T19:17:42Z

@terrytangyuan green!

terrytangyuan · 2022-10-17T19:47:18Z

Actually just one last failing test!

terrytangyuan · 2022-10-17T19:47:49Z

.github/workflows/ci-build.yaml

@@ -86,7 +86,19 @@ jobs:
            profile: minimal
          - test: test-python-sdk
            profile: minimal
+          - test: test-executor
+            install_k3s_version: v1.21.2+k3s1


Hmm this is not right?

This is the version were running

We should be testing 1.24

It defaults to latest (v1.25 ATM). These are for testing backwards compatibility.

I see. Can we rename these tests to differentiate them from the existing ones? It might be better to explicitly set the version so that we know what change breaks the tests?

Yes/no. I wast trying to avoid forcing all the required checks to be changed. That impacts all PRs, which would need to be synced with master.

Using latest reduces maintenance, we don’t need to update it.

sarabala1979 · 2022-10-17T19:52:52Z

docs/manually-create-secrets.md

+
+This option is simpler than option 2, as you can combine creating the secret with making it discoverable by name.
+
+## Option 2 - Discovery By Annotation


are we going to support both options? I didn't code for it. Will k8s automatically support this?

This is only if there are long service account names, or secret already exists.

terrytangyuan

LGTM. @sarabala1979 Take another look?

Signed-off-by: Alex Collins <[email protected]> Signed-off-by: Alex Collins <[email protected]> Signed-off-by: juchao <[email protected]>

sarabala1979 mentioned this pull request Sep 22, 2022

Image pull error: User "system:serviceaccount:argo:argo-helm-argo-workflows-workflow-controller" cannot get resource "secrets" in API group "" in the namespace "mynamespace" #9630

Closed

3 tasks

terrytangyuan mentioned this pull request Sep 25, 2022

fix: Support Kubernetes v1.24. Fixes #8320 #9680

Closed

terrytangyuan closed this Sep 25, 2022

terrytangyuan deleted the fix-8320 branch September 25, 2022 00:43

alexec restored the fix-8320 branch October 11, 2022 01:14

alexec deleted the fix-8320 branch October 11, 2022 01:14

alexec restored the fix-8320 branch October 11, 2022 14:43

alexec reopened this Oct 11, 2022

alexec commented Oct 13, 2022

View reviewed changes

docs/manually-create-secrets.md Outdated Show resolved Hide resolved

liggitt reviewed Oct 14, 2022

View reviewed changes

docs/manually-create-secrets.md Outdated Show resolved Hide resolved

alexec commented Oct 14, 2022

View reviewed changes

.github/workflows/ci-build.yaml Outdated Show resolved Hide resolved

alexec commented Oct 14, 2022

View reviewed changes

manifests/quick-start/mysql/mysql-deployment.yaml Outdated Show resolved Hide resolved

fix: Support Kubernetes v1.24. Fixes #8320

8a69080

Signed-off-by: Alex Collins <[email protected]>

alexec force-pushed the fix-8320 branch from cde31c9 to 8a69080 Compare October 15, 2022 00:01

fix: remove MySQL readiness check

689778c

Signed-off-by: Alex Collins <[email protected]>

alexec commented Oct 15, 2022

View reviewed changes

manifests/quick-start/mysql/mysql-deployment.yaml Show resolved Hide resolved

alexec added 2 commits October 15, 2022 07:57

Update manually-create-secrets.md

b83128f

Signed-off-by: Alex Collins <[email protected]>

Merge branch 'master' into fix-8320

58fa693

alexec marked this pull request as ready for review October 15, 2022 15:27

alexec enabled auto-merge (squash) October 15, 2022 15:27

terrytangyuan reviewed Oct 15, 2022

View reviewed changes

docs/manually-create-secrets.md Outdated Show resolved Hide resolved

.github/workflows/ci-build.yaml Outdated Show resolved Hide resolved

alexec added 4 commits October 15, 2022 19:57

docs: fix docs

96f8c90

Signed-off-by: Alex Collins <[email protected]>

ci: revert to install

dacb92b

Signed-off-by: Alex Collins <[email protected]>

test: error diagnostics

e20dfd7

Signed-off-by: Alex Collins <[email protected]>

ci: MySQL readiness TCP

dc5d7ad

Signed-off-by: Alex Collins <[email protected]>

terrytangyuan disabled auto-merge October 16, 2022 12:37

build: better free port

8c9295a

Signed-off-by: Alex Collins <[email protected]>

alexec added 2 commits October 16, 2022 08:32

ci: set-up env

a8eadd1

Signed-off-by: Alex Collins <[email protected]>

ci: set-up env

244d983

Signed-off-by: Alex Collins <[email protected]>

alexec commented Oct 16, 2022

View reviewed changes

alexec and others added 7 commits October 16, 2022 09:07

fix: ok

7878acc

M .github/workflows/ci-build.yaml M hack/free-port.sh Signed-off-by: Alex Collins <[email protected]>

ci: apt-get -y install socat

88690c4

Signed-off-by: Alex Collins <[email protected]>

Update ci-build.yaml

12d51a1

Signed-off-by: Alex Collins <[email protected]>

test: correct API test

838f19e

Signed-off-by: Alex Collins <[email protected]>

test: start pf

e78ad75

Signed-off-by: Alex Collins <[email protected]>

test: refactor

b7147cc

Signed-off-by: Alex Collins <[email protected]>

Merge branch 'master' into fix-8320

19bf9b0

terrytangyuan reviewed Oct 17, 2022

View reviewed changes

sarabala1979 reviewed Oct 17, 2022

View reviewed changes

terrytangyuan approved these changes Oct 18, 2022

View reviewed changes

alexec merged commit 36646ef into master Oct 19, 2022

alexec deleted the fix-8320 branch October 19, 2022 01:05

sarabala1979 mentioned this pull request Nov 8, 2022

v3.3 Cherry-picking #10000

Closed

agilgur5 added area/api Argo Server API area/server area/controller Controller issues, panics area/sso-rbac labels Jul 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Support Kubernetes v1.24. Fixes #8320 #9620

fix: Support Kubernetes v1.24. Fixes #8320 #9620

alexec commented Sep 19, 2022 •

edited

Loading

terrytangyuan commented Sep 25, 2022

alexec commented Oct 14, 2022

alexec commented Oct 15, 2022

terrytangyuan left a comment

alexec Oct 16, 2022

alexec Oct 16, 2022

alexec commented Oct 17, 2022

terrytangyuan commented Oct 17, 2022

terrytangyuan Oct 17, 2022

alexec Oct 18, 2022

terrytangyuan Oct 18, 2022

alexec Oct 18, 2022

terrytangyuan Oct 18, 2022

alexec Oct 18, 2022

sarabala1979 Oct 17, 2022

alexec Oct 18, 2022 •

edited

Loading

terrytangyuan left a comment


		This option is simpler than option 2, as you can combine creating the secret with making it discoverable by name.

		## Option 2 - Discovery By Annotation

fix: Support Kubernetes v1.24. Fixes #8320 #9620

fix: Support Kubernetes v1.24. Fixes #8320 #9620

Conversation

alexec commented Sep 19, 2022 • edited Loading

terrytangyuan commented Sep 25, 2022

alexec commented Oct 14, 2022

alexec commented Oct 15, 2022

terrytangyuan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexec commented Oct 17, 2022

terrytangyuan commented Oct 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexec Oct 18, 2022 • edited Loading

Choose a reason for hiding this comment

terrytangyuan left a comment

Choose a reason for hiding this comment

alexec commented Sep 19, 2022 •

edited

Loading

alexec Oct 18, 2022 •

edited

Loading