fix: for pod that's been GC'ed we need to get the log from the artifact #9540
Conversation
Signed-off-by: Julie Vogelman <[email protected]>
|
Note there's a very rare case in which isPendingOrRunning=true and the Pod gets deleted immediately after, such that by the time we make the call on line 216 it fails because the Pod's been deleted. Seems rare enough that I'm not sure we want to worry about it, though. |
Pull request was converted to draft
|
converting to draft for the moment just so I can do testing with different types of Workflows just to make sure no issues |
done. tested under various different circumstances different workflows |
|
@terrytangyuan Sorry, I know you enabled auto-merge, but I accidentally un-did that when I converted to draft and then back to "ready for review". Would you mind merging this? |
|
@terrytangyuan Thank you for being so on top of these PRs! |
Sure. Thanks for your fixes! |
…ct (argoproj#9540) Signed-off-by: juchao <[email protected]>
Signed-off-by: Julie Vogelman [email protected]
Fixes #9434
This fixes the use case that a Pod has been GC'ed and enables the UI to get the log from the artifact in this case.
This reverts a change made to this function here.