fix: check for nil, and add logging to expose root cause of panic in Issue 8968 #9010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
juliev0
changed the title
juliev0
commented
Jun 20, 2022
| woc.log.Error(err) | ||
| woc.markWorkflowError(ctx, err) | ||
| return node, err | ||
| } |
There was a problem hiding this comment.
I'm no expert on this code, but I assume it should error if node is nil. ? If not, I will move the error to where we try to reference node below.
There was a problem hiding this comment.
I think here is fine
looking at the original commit
https://github.com/argoproj/argo-workflows/pull/1552/files#diff-f321d4af83fcf8311dc80c0d50c59ac4c240f761206e7bb652709870eb9feb43R1224
The purpose of getting the node here is to retrieve node info after executing node base on template (step/dag..)
One way to look at this is Retry should be based on some kind of node template, so in theory, if there's no template there's no retry.
sarabala1979
approved these changes
Jun 22, 2022
3 tasks
sarabala1979
pushed a commit
that referenced
this pull request
Jun 23, 2022
…Issue 8968 (#9010) * fix: add logging to expose root cause of panic Signed-off-by: Julie Vogelman <[email protected]> * fix: empty commit Signed-off-by: Julie Vogelman <[email protected]> * fix: empty commit Signed-off-by: Julie Vogelman <[email protected]>
jmeridth
added a commit
to jmeridth/argo-helm
that referenced
this pull request
Jun 24, 2022
[Release Notes](https://github.com/argoproj/argo-workflows/releases/tag/v3.3.8) Includes: - fix: check for nil, and add logging to expose root cause of panic in Issue 8968 (argoproj/argo-workflows#9010) Signed-off-by: jmeridth <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julie Vogelman [email protected]
This is for the purpose of helping to diagnose the panic from Issue 8968. Seems to have panicked either because 'node' or 'retryNode' is nil.