feat: log workflow size before hydrating/dehydrating. Fixes #8976 #8988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8976 Signed-off-by: Dillen Padhiar <[email protected]>
Signed-off-by: Dillen Padhiar <[email protected]>
Signed-off-by: Dillen Padhiar <[email protected]>
Signed-off-by: Dillen Padhiar <[email protected]>
sarabala1979
approved these changes
Jun 18, 2022
sarabala1979
pushed a commit
that referenced
this pull request
Jun 23, 2022
) * feat: log workflow size before hydrating/dehydrating. Fixes #8976 Signed-off-by: Dillen Padhiar <[email protected]> * feat: added log field to previous log statement Signed-off-by: Dillen Padhiar <[email protected]> * feat: moved log for workflow size to hydrator.go Signed-off-by: Dillen Padhiar <[email protected]> * feat: move log in Hydrate() Signed-off-by: Dillen Padhiar <[email protected]>
juliev0
pushed a commit
to juliev0/argo-workflows
that referenced
this pull request
Jul 14, 2022
…8976 (argoproj#8988) * feat: log workflow size before hydrating/dehydrating. Fixes argoproj#8976 Signed-off-by: Dillen Padhiar <[email protected]> * feat: added log field to previous log statement Signed-off-by: Dillen Padhiar <[email protected]> * feat: moved log for workflow size to hydrator.go Signed-off-by: Dillen Padhiar <[email protected]> * feat: move log in Hydrate() Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: Julie Vogelman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dillen Padhiar [email protected]
Fixes #8976
If a workflow fails to be hydrated / dehydrated, it can be hard to tell what the issue may be. Many times, it may be because the workflow is too large and thus this change will log the size of the workflow so they may investigate for this case.