Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflowMetadata needs to be loaded into globalParams in both ArgoServer and Controller #8907

Merged
merged 15 commits into from
Jun 9, 2022

Conversation

juliev0
Copy link
Contributor

@juliev0 juliev0 commented Jun 3, 2022

Signed-off-by: Julie Vogelman [email protected]

Fixes #8837

…goServer and Controller

Signed-off-by: Julie Vogelman <[email protected]>
@juliev0 juliev0 marked this pull request as draft June 3, 2022 17:48
juliev0 added 14 commits June 3, 2022 11:08
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
This reverts commit 68682d8.

Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
…ws reference WorkflowTemplates

Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
… referencing a workflowMetadata label works

Signed-off-by: Julie Vogelman <[email protected]>
@juliev0 juliev0 marked this pull request as ready for review June 9, 2022 05:24
@sarabala1979 sarabala1979 self-assigned this Jun 9, 2022
@sarabala1979 sarabala1979 merged commit ede1a39 into argoproj:master Jun 9, 2022
@juliev0 juliev0 deleted the wf-metadata branch June 9, 2022 16:20
This was referenced Jun 20, 2022
@sarabala1979 sarabala1979 mentioned this pull request Jul 30, 2022
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot submit WorkflowTemplate with {{workflow.labels.xxxx}} values from v3.3.0
3 participants