Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed podName in killing daemon pods. Fixes #8692 #8708

Merged
merged 1 commit into from
May 11, 2022
Merged

fix: Fixed podName in killing daemon pods. Fixes #8692 #8708

merged 1 commit into from
May 11, 2022

Conversation

KesavanKing
Copy link
Contributor

Signed-off-by: i342464 [email protected]

Fixes #8692

@terrytangyuan terrytangyuan requested a review from JPZ13 May 11, 2022 13:50
Copy link
Member

@JPZ13 JPZ13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@terrytangyuan terrytangyuan merged commit 9ddae87 into argoproj:master May 11, 2022
@KesavanKing KesavanKing deleted the daemon-podname branch May 12, 2022 06:42
This was referenced Jun 20, 2022
@sarabala1979 sarabala1979 mentioned this pull request Jul 30, 2022
51 tasks
sarabala1979 pushed a commit that referenced this pull request Aug 8, 2022
Signed-off-by: i342464 <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daemon containers not getting destroyed when enabling POD_NAMES as v2
3 participants