Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enhance artifact visualization. Fixes #8619 #8655

Merged
merged 3 commits into from
May 6, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 6, 2022

Signed-off-by: Alex Collins [email protected]

Fixes #8619

  • Made artifact panel wider (50%) to make it easie to see large artifacts.
  • Filter out artifacts from the DAG that cannot be visualized (only show files and folders).
  • Update CSP to allow inline-styles, so pages can be styled nicer.
  • Updated examples to make them less trivial.
  • Fixed a bug where Git artifacts key ignore the branch.
  • Fixed new and old bugs, annoyances, and out of date help in the log viewer.
  • Fix bug in persistence of the DAGS horizontal/vertical toggle. The horizontal/vertical option on the graph panel does not persist #8619

- |
mkdir -p /out/assets
- name: gnuplot
image: remuslazar/gnuplot
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnuplot can create some nice charts.

args:
- |
go install github.com/jstemmer/go-junit-report@latest
go install github.com/alexec/[email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to write this myself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this in our examples folder as it's a simple script?

Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as ready for review May 6, 2022 17:06
@alexec alexec enabled auto-merge (squash) May 6, 2022 17:06
@alexec alexec requested a review from terrytangyuan May 6, 2022 17:15
@terrytangyuan terrytangyuan self-assigned this May 6, 2022
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small comment but not a blocker.

Signed-off-by: Alex Collins <[email protected]>
@alexec alexec merged commit 3fdf30d into argoproj:master May 6, 2022
@alexec alexec deleted the fix-8619 branch May 6, 2022 18:48
@alexec alexec linked an issue May 6, 2022 that may be closed by this pull request
@sarabala1979 sarabala1979 mentioned this pull request May 25, 2022
14 tasks
This was referenced Jun 20, 2022
@sarabala1979 sarabala1979 mentioned this pull request Jul 30, 2022
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants