fix: Terminate, rather than delete, deadlined pods. Fixes #8545 #8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <[email protected]>
alexec
changed the title
alexec
commented
May 5, 2022
| @@ -468,24 +468,6 @@ func (wfc *WorkflowController) processNextPodCleanupItem(ctx context.Context) bo | |||
| err := func() error { | |||
| pods := wfc.kubeclientset.CoreV1().Pods(namespace) | |||
| switch action { | |||
| case shutdownPod: | |||
There was a problem hiding this comment.
this isn't needed anymore
Signed-off-by: Alex Collins <[email protected]>
sarabala1979
approved these changes
May 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins [email protected]
Fixes #8545
Problem: When a step hits it deadline, we delete the pod. Because we delete the pod, we loose all information about the success or failure of the pod. Instead of deleting, we must SIGTERM the pod's containers.