Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Conditionals example improved with complex syntax #5467

Merged
merged 8 commits into from
Mar 25, 2021

Conversation

sylock
Copy link
Contributor

@sylock sylock commented Mar 19, 2021

Checklist:

@sylock
Copy link
Contributor Author

sylock commented Mar 19, 2021

Related to #860

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #5467 (73b3e60) into master (3065941) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 73b3e60 differs from pull request most recent head 7a58303. Consider uploading reports for the commit 7a58303 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5467      +/-   ##
==========================================
+ Coverage   46.54%   46.71%   +0.16%     
==========================================
  Files         240      240              
  Lines       15001    14994       -7     
==========================================
+ Hits         6982     7004      +22     
+ Misses       7119     7092      -27     
+ Partials      900      898       -2     
Impacted Files Coverage Δ
util/errors/errors.go 100.00% <100.00%> (ø)
pkg/apiclient/apiclient.go 5.55% <0.00%> (-4.45%) ⬇️
cmd/argo/commands/get.go 56.66% <0.00%> (ø)
pkg/apiclient/http1-client.go 0.00% <0.00%> (ø)
pkg/apiclient/logs-intermediary.go 0.00% <0.00%> (ø)
pkg/apiclient/http1/event-watch-client.go 0.00% <0.00%> (ø)
...lient/error-translating-workflow-service-client.go 0.00% <0.00%> (ø)
...o-kube-cluster-workflow-template-service-client.go 0.00% <0.00%> (ø)
workflow/controller/operator.go 70.53% <0.00%> (+0.27%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3065941...7a58303. Read the comment docs.

@simster7 simster7 changed the title Conditionals example improved with complex syntax docs: Conditionals example improved with complex syntax Mar 19, 2021
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simster7
Copy link
Member

@sylock Looks like you'll need to run make docs. Also, please make sure to sign your commits by using the -s flag: git commit -asm "message"

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make codegen needs running

@sylock
Copy link
Contributor Author

sylock commented Mar 24, 2021

I'm sorry but make codegen is still not working from my side:

  • Do you have some documentation about how to setup properly a dev environment
  • It would be nice to have an easier entry barrier to contributing, especially for documentation (I'm not a golang dev)
make codegen
error: current-context is not set
# GIT_TAG=v2.10.0-rc1, GIT_BRANCH=master, GIT_TREE_STATE=clean, VERSION=latest, DEV_IMAGE=true, K3D=false
go mod vendor
warning: ignoring symlink /home/sylock/dev/argo/docs/examples
go install ./vendor/github.com/go-swagger/go-swagger/cmd/swagger
go install ./vendor/github.com/gogo/protobuf/protoc-gen-gogo
go install ./vendor/github.com/gogo/protobuf/protoc-gen-gogofast
go install ./vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway
go install ./vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger
go install ./vendor/k8s.io/code-generator/cmd/go-to-protobuf
go install ./vendor/k8s.io/kube-openapi/cmd/openapi-gen
go install ./vendor/sigs.k8s.io/controller-tools/cmd/controller-gen
rm -Rf vendor
go get golang.org/x/tools/cmd/[email protected]
go: found golang.org/x/tools/cmd/goimports in golang.org/x/tools v0.0.0-20200630154851-b2d8b0336632
./hack/generate-proto.sh
+ go mod vendor
warning: ignoring symlink /home/sylock/dev/argo/docs/examples
./hack/generate-proto.sh: line 7: GOPATH: unbound variable
make: *** [Makefile:277: proto] Error 1
``

@alexec
Copy link
Contributor

alexec commented Mar 24, 2021

I'm sorry but make codegen is still not working from my side:

I tend to copy the patch and use git apply to update codegen when the CI prints the diffs.

@simster7
Copy link
Member

@sylock I ran codegen for you

@alexec alexec merged commit 24ccdf4 into argoproj:master Mar 25, 2021
This was referenced Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants