Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose workflow.paramteres with JSON string of all params #2341

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Mar 2, 2020

Closes: #2242

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d8a9ea0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2341   +/-   ##
=========================================
  Coverage          ?   13.31%           
=========================================
  Files             ?       72           
  Lines             ?    24606           
  Branches          ?        0           
=========================================
  Hits              ?     3276           
  Misses            ?    20917           
  Partials          ?      413
Impacted Files Coverage Δ
workflow/controller/operator.go 61.91% <100%> (ø)
workflow/validate/validate.go 74.65% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a9ea0...2c75085. Read the comment docs.

Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simster7 simster7 merged commit 5895b36 into argoproj:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make workflow.parameters accessible as a JSON string
2 participants