fix!: remove 1s sleep and INFORMER_WRITE_BACK from persistUpdates#15627
Merged
isubasinghe merged 1 commit intoargoproj:mainfrom Feb 26, 2026
Merged
Conversation
The INFORMER_WRITE_BACK env var controlled whether to write back to the informer cache or sleep for 1 second after persisting workflow updates. Alternative mechanisms now prevent reprocessing of stale workflow state, making both the sleep and the write-back unnecessary. https://claude.ai/code/session_0141wLcUV65wmraQEVWnLkv6 Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
changed the title
isubasinghe
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As of #15079 INFORMER_WRITE_BACK is disabled, so remove it to prevent it's use as it's considered harmful.
As of #15090 we have alternative mechanisms to prevent processing out of date workflows, so don't sleep for 1 second any more either.
Modifications
The INFORMER_WRITE_BACK env var controlled whether to write back to the informer cache or sleep for 1 second after persisting workflow updates. Alternative mechanisms now prevent reprocessing of stale workflow state, making both the sleep and the write-back unnecessary.
Verification
TODO
Documentation
Updated to remove the env variable and added a note for upgraders.