Skip to content

chore(manifests): switch to full CRDs by default#15003

Merged
Joibel merged 4 commits intoargoproj:mainfrom
MasonM:swtich-to-full-CRDs
Dec 1, 2025
Merged

chore(manifests): switch to full CRDs by default#15003
Joibel merged 4 commits intoargoproj:mainfrom
MasonM:swtich-to-full-CRDs

Conversation

@MasonM
Copy link
Copy Markdown
Member

@MasonM MasonM commented Nov 3, 2025

Motivation

After the work in #14044, the full CRDs are now usable, and no issues have been reported. This switches the install manifests to use them by default.

Modifications

Update the the kustomization.yaml files to reference the full CRDs

Verification

Ran make manifests-validate (which is also run in CI builds)

Documentation

Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
@MasonM MasonM force-pushed the swtich-to-full-CRDs branch from abfd0ed to ed8ff6c Compare November 3, 2025 04:41
@MasonM
Copy link
Copy Markdown
Member Author

MasonM commented Nov 3, 2025

/retest

Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
@MasonM MasonM marked this pull request as ready for review December 1, 2025 00:59
@MasonM MasonM requested a review from Joibel December 1, 2025 01:18
Copy link
Copy Markdown
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

```bash
kubectl apply --server-side --kustomize https://github.com/argoproj/argo-workflows/manifests/base/crds/full?ref=v3.7.0
```

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to leave in instructions for using SSA to install (perhaps on the releases page), otherwise people will struggle. Perhaps we should also have the inverted instructions for the minified CRDs here, at least until we discover if anyone needs them.

@Joibel Joibel merged commit f9f6b0d into argoproj:main Dec 1, 2025
41 checks passed
guanguxiansheng pushed a commit to guanguxiansheng/argo-workflows that referenced this pull request Dec 15, 2025
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants