fix: Fixes parameterized global artifacts resolution in exit handlers. Fixes #11610

[ItielOlenick]

Fixes #11610

Motivation

Workflows with parameterized global artifact names (e.g., globalName: output-result-{{inputs.parameters.variable}}) fail validation in exit handlers after v3.4.6 with
errors like "failed to resolve {{workflow.outputs.artifacts.output-result-car}}". This worked correctly in v3.4.5 and earlier.

Modifications

• Added pre-scan in exit handler validation to detect parameterized global artifacts
• Enable anyWorkflowOutputArtifactMagicValue when parameterized global artifacts exist
• Added comprehensive unit tests covering the regression scenario

Verification

• Unit tests reproduce the exact failure and verify the fix
• Existing validation tests continue to pass
• Runtime artifact resolution remains unchanged

Documentation

No documentation changes needed - this restores existing functionality that was inadvertently broken.

[elliotgunton]

Hey @ItielOlenick, I was looking to review this as I recently fixed a similar issue in #15033. As part of that I refactored the anyVarNotInEnv function so it would be worth a careful rebase/merge first so we can be sure that the code is up to date before reviewing.

It looks like you'd just need to ensure your code commented with Special handling is carried over, i.e. to add the

		if strings.HasPrefix(variable, "workflow.outputs.") {
				continue
			}

part and from envForCompilation := env. The anyVarNotInEnv is now only called once and checks through all special case variables at once (returning the name of the referenced variable), so the workflowVariables will be removed entirely when you rebase/merge. Thanks! 🚀

[ItielOlenick]

@elliotgunton After taking a look at your changes and doing some more testing, I removed all of the expression related changes as they seemed unnecessary and left only the validation ones.
Ready for a review

[elliotgunton]

LGTM 🚀

[Joibel]

Whilst testing this I've noticed a couple of things - I'll also take the test from #11610 and turn it into an e2e test

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.7. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.6. Please check the workflow logs for details.