fix(ui): switch from js-yaml
to yaml
. Fixes #12205
#13750
Merged
+142
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12205
Motivation
js-yaml has had no releases in over 3 years. Also, the fact it only supports YAML 1.2 is leading to bugs, since Kubernetes uses YAML 1.1 (see kubernetes/kubernetes#34146).
Modifications
This switches over to yaml, which had a release last month, is licensed under ISC, and supports YAML 1.1. I also added test cases for the parsing/stringifying code.
Verification
Copied the example from #12205 over to http://localhost:8080/workflow-templates and verified the
mode: 0755
was changed tomode: 493
:fix-12205.mp4