Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only set ARGO_PROGRESS_FILE when needed. Partial fix for #13089 #13743

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

tooptoop4
Copy link
Contributor

@tooptoop4 tooptoop4 commented Oct 11, 2024

Fixes point 5 of #13089

ARGO_PROGRESS_FILE is only used when self reporting progress

@tooptoop4 tooptoop4 changed the title fix: only set ARGO_PROGRESS_FILE if self reporting progress (#13089) fix: only set ARGO_PROGRESS_FILE if self reporting progress (#13089) Oct 11, 2024
@agilgur5 agilgur5 changed the title fix: only set ARGO_PROGRESS_FILE if self reporting progress (#13089) fix: only set ARGO_PROGRESS_FILE if self reporting progress. Partial fix for #13089 Oct 12, 2024
@agilgur5 agilgur5 changed the title fix: only set ARGO_PROGRESS_FILE if self reporting progress. Partial fix for #13089 fix: only set ARGO_PROGRESS_FILE if self reporting progress. Partial fix for #13089 Oct 12, 2024
@agilgur5 agilgur5 added the area/controller Controller issues, panics label Oct 12, 2024
@agilgur5 agilgur5 changed the title fix: only set ARGO_PROGRESS_FILE if self reporting progress. Partial fix for #13089 fix: only set ARGO_PROGRESS_FILE when needed. Partial fix for #13089 Oct 12, 2024
@juliev0 juliev0 merged commit a8c3609 into argoproj:main Oct 15, 2024
32 of 33 checks passed
@tooptoop4 tooptoop4 mentioned this pull request Oct 19, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics area/executor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants