Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CHANGELOG.md for v3.6.0-rc1 #13617

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Joibel Joibel self-assigned this Sep 18, 2024
@Joibel Joibel added the area/docs Incorrect, missing, or mistakes in docs label Sep 18, 2024
Attempt to trigger CI

Signed-off-by: Alan Clucas <[email protected]>
@Joibel Joibel merged commit 53e5461 into main Sep 18, 2024
15 checks passed
@Joibel Joibel deleted the create-pull-request/changelog branch September 18, 2024 12:18
@agilgur5
Copy link
Contributor

agilgur5 commented Sep 18, 2024

@Joibel, per the releasing docs, you just need to push an empty commit to run CI, there's a sample command and message there too (that previous changelog PRs have).
The commit shouldn't contain anything, and changes to the CHANGELOG will get undone by the generator too next run.

No biggie, but just an FYI so you know

@agilgur5
Copy link
Contributor

Also we should create a new 3.6 releases issue similar to #11997 and link this PR there

@Joibel
Copy link
Member

Joibel commented Sep 18, 2024

Also we should create a new 3.6 releases issue similar to #11997 and link this PR there

This wasn't done previously until the first non-RC it seems e.g. v3.5.0

I had planned to do this when we made the release-3.6 branch. I'm not expecting this RC to be the only one because of how long it's been since 3.5, but once we've got some more testing in I may do that at RC-2 or 3, and create a tracking issue at the same time.

@agilgur5
Copy link
Contributor

agilgur5 commented Sep 18, 2024

Originally that was because those issues were only for requests for backports, which don't apply to RCs since everything on main is included.

I still think the issue is useful purely for a place to make announcements and track all releases. Including for users to subscribe to (they can subscribe to repo releases as well, but some users are awaiting a certain feature/fix and so want more nuanced updates including a link to the CHANGELOG PR etc). That's mostly what I've used the 3.5 issue for since I've been doing backports (where I've tried to include as much as possible without specifics user requests). It's also a central place for users to upvote requests for another release and a general reference to link to for user questions

@agilgur5 agilgur5 added this to the v3.6.0 milestone Sep 20, 2024
agilgur5 pushed a commit that referenced this pull request Sep 20, 2024
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Alan Clucas <[email protected]>
Co-authored-by: Joibel <[email protected]>
Co-authored-by: Alan Clucas <[email protected]>
(cherry picked from commit 53e5461)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants